cli: show favicon and fix title on auth success page#187
Draft
jarugupj wants to merge 1 commit into
Draft
Conversation
The browser page shown after `kernel login` had no favicon, so browsers fell back to the default icon. Embed the Kernel favicon inline as an SVG data URI so it renders without a follow-up request (the local callback server stops right after serving the page). The title used an em-dash that rendered as mojibake because the page declares no charset. Replace it with a hyphen. Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The browser page shown after
kernel login(pkg/auth/success.html) had two issues, both visible in the tab:/favicon.ico) avoids a race with the local callback server, which shuts down immediately after serving the page, so a follow-up request for the icon would fail.<title>used an em-dash that rendered as mojibake (â€") because the page declares no charset. Swapped it for a hyphen so the tab readskernel cli - authenticated.Test plan
go build ./...passeskernel login, confirm the browser tab shows the Kernel favicon and the title readskernel cli - authenticated(both live in browser chrome, which headless screenshots can't capture)